New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CanPowerDown with ToggleConditionOnOrder. #14583

Merged
merged 2 commits into from Dec 27, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 26, 2017

Closes #14175.

Testcase:

  • Deploying the radar dome or tesla coil should prevent the powerdown cursor from working.
  • Deploying the radar dome or tesla coil while powered down should remove the power down.
  • Deploying the radar dome while powered down resets the powerdown toggle (remains powered up when redeployed).
  • Deploying the tesla coil while powered down does not reset the powerdown toggle (powers down again when redeployed).
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 26, 2017

Member

Fixed.

Member

pchote commented Dec 26, 2017

Fixed.

WithDecoration@POWERDOWN:
Image: poweroff
Sequence: offline
Palette: chrome
RequiresCondition: powerdown
ReferencePoint: Center
PowerMultiplier@POWERDOWN:
RequiresCondition: powerdown
Modifier: 0

This comment has been minimized.

@reaperrr

reaperrr Dec 26, 2017

Contributor

This makes several yaml entries redundant (in all our mods with the power-down option), for example on IRON in RA:

	Power:
		RequiresCondition: !powerdown
@reaperrr

reaperrr Dec 26, 2017

Contributor

This makes several yaml entries redundant (in all our mods with the power-down option), for example on IRON in RA:

	Power:
		RequiresCondition: !powerdown

This comment has been minimized.

@pchote

pchote Dec 26, 2017

Member

Done.

@pchote

pchote Dec 26, 2017

Member

Done.

@reaperrr

Code looks good and all testcases work

@obrakmann

Looks good to me, 👍

Please remove the testcase

@pchote pchote dismissed stale reviews from obrakmann and reaperrr via c3ea11e Dec 27, 2017

@pchote pchote removed the PR: Rebase me! label Dec 27, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 27, 2017

Member

Done

Member

pchote commented Dec 27, 2017

Done

@obrakmann

👍 stands, no change to the code

@obrakmann obrakmann merged commit c6ad768 into OpenRA:bleed Dec 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Dec 27, 2017

@pchote pchote deleted the pchote:toggle-condition-on-order branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment