New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K carryall pickup indicator offset fix #14585

Merged
merged 2 commits into from Dec 27, 2017

Conversation

Projects
None yet
5 participants
@fruestueck
Contributor

fruestueck commented Dec 27, 2017

This Fixes #14487 jumping pickup-indicator when zooming in/out.

EDIT: ReferencePoint: Top, Left, Offset adjusted as seen on compare_image.
Also the icons should scale on zoom.

d2k Vanilla video source

@GraionDilach

👍

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 27, 2017

Member

I always interpreted the original as having it inset from the corner rather than offset from the origin, and so to be consistent with our other decorations can we please attach this back to the TopLeft?
Having the health bars and icons not scale with zoom was a deliberate design decision (they are tactical overlays, and not part of the world itself).

Member

pchote commented Dec 27, 2017

I always interpreted the original as having it inset from the corner rather than offset from the origin, and so to be consistent with our other decorations can we please attach this back to the TopLeft?
Having the health bars and icons not scale with zoom was a deliberate design decision (they are tactical overlays, and not part of the world itself).

@fruestueck

This comment has been minimized.

Show comment
Hide comment
@fruestueck

fruestueck Dec 27, 2017

Contributor

I agree @pchote. Changed it acordingly ( see image in top post).
Maby the offset could use a slight adjustment. What do you think?

Contributor

fruestueck commented Dec 27, 2017

I agree @pchote. Changed it acordingly ( see image in top post).
Maby the offset could use a slight adjustment. What do you think?

@pchote

pchote approved these changes Dec 27, 2017

LGTM, thanks!

@pchote pchote merged commit b8ec20a into OpenRA:bleed Dec 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fruestueck fruestueck deleted the fruestueck:fix_d2k_carryall_pickupindicator branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment