New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PortableChrono regressions #14608

Merged
merged 2 commits into from Jan 1, 2018

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 31, 2017

Fixes #14606.

@pchote pchote added this to the Next release milestone Dec 31, 2017

if (CanTeleport)
self.World.OrderGenerator = new PortableChronoOrderGenerator(self, Info);
// HACK: We need to issue a fake order to stop the game complaining about the bodge above

This comment has been minimized.

@pchote

pchote Dec 31, 2017

Member

Note that this is restoring and documenting the workaround that I removed in #13995 after assuming it was just unintentional bad code.

@pchote

pchote Dec 31, 2017

Member

Note that this is restoring and documenting the workaround that I removed in #13995 after assuming it was just unintentional bad code.

@abcdefg30 abcdefg30 merged commit cd6dfd2 into OpenRA:bleed Jan 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Jan 1, 2018

@pchote pchote deleted the pchote:fix-portablechrono-regressions branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment