New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to remove tooltips that haven't been added. #14622

Merged
merged 1 commit into from Jan 1, 2018

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Jan 1, 2018

Fixes @abcdefg30's playtest crash.

Repro case: move the mouse over the players column in the server browser (for a different mod/version) and then quickly double click to join before the player tooltip appears (or would, if it could). Then move the mouse after the switch mod dialog appears.

The crash happens because the MouseExit tries to instantiate a tooltip container that no longer exists. The fix is to make sure it doesn't do that.

@pchote pchote added this to the Next release milestone Jan 1, 2018

@penev92

penev92 approved these changes Jan 1, 2018

@penev92 penev92 merged commit 7b05650 into OpenRA:bleed Jan 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment