Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lua functions for DeliverCash and DeliverExperience #14791

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Feb 6, 2018

Testcase adds a supply truck moving to AlliedConyard on ra shellmap.

truck.Move(TruckWP3.Location)
truck.DeliverCash(AlliedConYard)

Trigger.AfterDelay(DateTime.Seconds(30), SendTruck)

This comment has been minimized.

@Mailaender

Mailaender Feb 18, 2018

Member
/home/matthias/Entwicklung/OpenRA//lua/sandbox.lua:150: [string "BindingSupport.lua"]:30: Uncaught CLR exception at Lua->CLR boundary: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at OpenRA.Mods.Common.Scripting.TriggerGlobal.AfterDelay (System.Int32 delay, Eluant.LuaFunction func) [0x00015] in <9625bc0a717d47ee85400cd20db8a379>:0

This comment has been minimized.

@Mailaender

Mailaender Feb 18, 2018

Member

Works fine when fixing the oversight:

-Trigger.AfterDelay(DateTime.Seconds(30), SendTruck)
+Trigger.AfterDelay(DateTime.Seconds(30), SendSupplyTruck)
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 18, 2018

Looks good to me, testcase can be removed now.

@MustaphaTR MustaphaTR dismissed stale reviews from reaperrr and Mailaender via 4bfbcde Feb 19, 2018

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:delivery-lua branch from e4d96da to 4bfbcde Feb 19, 2018

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Feb 19, 2018

Removed testcase.

@reaperrr reaperrr merged commit c4b0ad4 into OpenRA:bleed Feb 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:delivery-lua branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.