Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA - Fix palette of Oil Pump, Ice, Boxes, Hedgehogs and Utility Poles on Desert Tileset #14815

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Feb 12, 2018

And remove Editor Exclution of them from Desert Tileset. Interior and Snow palettes are literally the same file as temprate.pal, so making them always use temperate.pal won't break anything on those and allow using them on Desert theater too. Not sure what can be done with Ice on desert, but still included them too.

@abcdefg30 abcdefg30 requested review from Mailaender and removed request for Mailaender Feb 12, 2018

@MustaphaTR MustaphaTR changed the title Fix palette of Oil Pump, Ice, Boxes, Hedgehogs and Utility Poles on Desert Tileset RA - Fix palette of Oil Pump, Ice, Boxes, Hedgehogs and Utility Poles on Desert Tileset Feb 13, 2018

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Feb 17, 2018

Would it make more sense to exclude ice from temperate instead of add it to desert?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 17, 2018

IMO yes.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 18, 2018

Agreed.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:ra-decor-palette branch from 8cb48ed to 38a34d2 Feb 18, 2018

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Feb 18, 2018

Updated, apart from limiting ice to snow, i also made CivBuildings and DesertRocks render properly on tilesets they are not meant to be in, if anyone manually places them by editing map.yaml. They are still not available on the editor.

I didn't do the trees becuase TC01 and T08 has desert variants and should use terrain specific palette, and i don't wanna do special case for some trees.

@reaperrr reaperrr merged commit 763da40 into OpenRA:bleed Feb 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 23, 2018

@MustaphaTR MustaphaTR deleted the MustaphaTR:ra-decor-palette branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.