Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ThrowsShrapnel conditional #14817

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
4 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Feb 13, 2018

No description provided.

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Feb 13, 2018

OpenRA.Mods.Common/Traits/ThrowsShrapnel.cs(34,15): error CS0114: Warning as Error: `OpenRA.Mods.Common.Traits.ThrowsShrapnelInfo.RulesetLoaded(OpenRA.Ruleset, OpenRA.ActorInfo)' hides inherited member `OpenRA.Mods.Common.Traits.ConditionalTraitInfo.RulesetLoaded(OpenRA.Ruleset, OpenRA.ActorInfo)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword
OpenRA.Mods.Common/Traits/Conditions/ConditionalTrait.cs(32,23): (Location of the symbol related to previous error)

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:conditional-throws-shrapnel branch from 5e95eba to a041ca8 Feb 13, 2018

@reaperrr reaperrr merged commit 0e0ab31 into OpenRA:bleed Feb 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:conditional-throws-shrapnel branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.