Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make.ps1 command shortcuts #14882

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
4 participants
@fruestueck
Copy link
Contributor

fruestueck commented Mar 4, 2018

Closes #14880 adding shortcuts to make.ps1 (make.cmd).

@fruestueck fruestueck changed the title Add make.ps1 commands shortcuts Add make.ps1 command shortcuts Mar 4, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Mar 4, 2018

@fruestueck

This comment has been minimized.

Copy link
Contributor Author

fruestueck commented Mar 4, 2018

Yes i did, but i would wait for more comments on #14880 (comment) before adding some highlighting. Just adding the shurtcut after the command doesn't look appealing. : )

EDIT: After some research i'd go with a simple solution. Write the shortcut next to the command or referr at the bottom of the commands, that there are shortcuts. What would you like?

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Mar 8, 2018

I'd go with

Write the shortcut next to the command

@fruestueck

This comment has been minimized.

Copy link
Contributor Author

fruestueck commented Mar 9, 2018

This adds 4 characters per line. Is it too big?
My cmd-window has more space per line so i can't really tell.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Mar 9, 2018

My cmd-window has more space per line so i can't really tell.

Same here. If it's that way for all or at least most Windows-users, it should be fine.

make.ps1 Outdated
echo " docs Generates the trait and Lua API documentation."
echo " all, a Builds the game and its development tools."
echo " dependencies, d Copies the game's dependencies into the main game folder."
echo " version, v Sets the version strings for the default mods to the latest"

This comment has been minimized.

@RoosterDragon

RoosterDragon Mar 10, 2018

Member

image

Can you wrap latest? It's 1 character too long on the default size.

This comment has been minimized.

@pchote

pchote Mar 10, 2018

Member

"Sets the version strings for the default mods to the latest" reads weirdly anyway, IMO, so how about shortening it to "Sets the version strings for the default mods"?

This comment has been minimized.

@fruestueck

fruestueck Mar 10, 2018

Author Contributor

I've just moved the last word into the next line, couse it's a twoliner anyway. Could be changed if still wanted.
Commits squashed

@fruestueck fruestueck force-pushed the fruestueck:make-short branch from a3cf530 to e428fcb Mar 10, 2018

make.ps1 Outdated
{"test", "t" -contains $_} { Test-Command }
{"check", "ck" -contains $_} { Check-Command }
{"check-scripts", "cs" -contains $_} { Check-Scripts-Command }
{"docs", "d" -contains $_} { Docs-Command }

This comment has been minimized.

@RoosterDragon

RoosterDragon Mar 10, 2018

Member

docs and dependencies both have d as the shorthand. I would just remove the shortcut for docs - it's short enough.

This comment has been minimized.

@fruestueck

fruestueck Mar 12, 2018

Author Contributor

Done. Otherwise we could give it 'o' as a shortcut

@fruestueck fruestueck force-pushed the fruestueck:make-short branch from 8d448dc to 63f4412 Mar 12, 2018

@RoosterDragon RoosterDragon merged commit 65c42a6 into OpenRA:bleed Mar 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fruestueck

This comment has been minimized.

Copy link
Contributor Author

fruestueck commented Mar 16, 2018

@RoosterDragon can you add a changelog entry? I'm lacking the necessary rights and knowhow.

@RoosterDragon

This comment has been minimized.

Copy link
Member

RoosterDragon commented Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.