Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actors with PauseOnCondition ammo not scanning for targets when reloading #14926

Merged
merged 1 commit into from Mar 18, 2018

Conversation

Projects
None yet
7 participants
@netnazgul
Copy link
Contributor

netnazgul commented Mar 16, 2018

Fixes #14921.

Introducing PauseOnCondition for V2RLs made them moving towards a-move point instead of acquiring targets and waiting for reload because when reloading they are now don't have any weapon to scan with. Explicit ScanRadius on AutoTarget trait amends this behaviour and forces actors to always scan not depending on the weapon they use.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 16, 2018

Is V2RL the only unit (across all the default mods) that needs to be fixed?

@netnazgul

This comment has been minimized.

Copy link
Contributor Author

netnazgul commented Mar 16, 2018

I thought that MLRS also used this, but don't see PauseOnCondition there, so they probably behave correctly.
PauseOnCondition is used on aircraft ammo where this fix is not needed.

upd: MLRS behave correctly on bleed without any changes.

@Smittytron
Copy link
Contributor

Smittytron left a comment

Works for me

@FrameLimiter

This comment has been minimized.

Copy link
Contributor

FrameLimiter commented Mar 17, 2018

The Orca & Heli have self reloading ammopools with paused armaments between reloads as well. They should also be included. (TD mod)

@netnazgul netnazgul force-pushed the netnazgul:v2rl_scan_fix branch from 65585bd to b90fb06 Mar 17, 2018

@netnazgul

This comment has been minimized.

Copy link
Contributor Author

netnazgul commented Mar 17, 2018

Added Orca (weapon range 5) and Apache (weapon range 4) fixes.

@FrameLimiter

This comment has been minimized.

Copy link
Contributor

FrameLimiter commented Mar 17, 2018

The name of both the pr & commit is specific to the V2RL. The titles should be updated.

@netnazgul netnazgul changed the title Fix V2RL not scanning for targets when weapon is empty Fix actors with PauseOnCondition ammo not scanning for targets when reloading Mar 17, 2018

@netnazgul netnazgul force-pushed the netnazgul:v2rl_scan_fix branch from b90fb06 to 96b1fc1 Mar 17, 2018

@netnazgul

This comment has been minimized.

Copy link
Contributor Author

netnazgul commented Mar 17, 2018

Names should be descriptive enough now

@reaperrr reaperrr merged commit b383b9a into OpenRA:bleed Mar 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Mar 18, 2018

@netnazgul netnazgul deleted the netnazgul:v2rl_scan_fix branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.