Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vision and VTOL husk to the carryall while in process of lifting harvesters. #14956

Merged
merged 1 commit into from Mar 25, 2018

Conversation

Projects
None yet
3 participants
@CH4Code
Copy link
Contributor

CH4Code commented Mar 20, 2018

This improves on the sudden vanishing of harvesters which get picked up by a carryall, leaving it unclear if the harvester has been destroyed or picked up via carryall. (Often you see some revealed region in preliminary eye vision vanish where only a harvester could have been, prompting a panic-check for enemy units.)
gentlevisionrecession
Also adds a husk in VTOL mode, so a carryall which gets killed no longer jerks forward if destroyed while in process of landing/picking up.

@ltem

This comment has been minimized.

Copy link
Contributor

ltem commented Mar 25, 2018

I like the solution but creating a new actor will interrupt attacks and I think this isn't wanted.
I'm not aware of a solution for this but maybe somebody else has an idea.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Mar 25, 2018

The new actor is just a husk variant, so I don't see any issue with this myself.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍 even.

@ltem ltem added the PR: Needs +2 label Mar 25, 2018

@ltem

This comment has been minimized.

Copy link
Contributor

ltem commented Mar 25, 2018

You are right but when I attack it via Missile Tanks during the landing procedure, the missile tanks stop at a certain point and continue after the Carryall reached the point again. I thought it was due to the actor but it is the same on bleed.

@ltem

ltem approved these changes Mar 25, 2018

@ltem ltem merged commit 5b24649 into OpenRA:bleed Mar 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ltem

This comment has been minimized.

Copy link
Contributor

ltem commented Mar 25, 2018

@CH4Code

This comment has been minimized.

Copy link
Contributor Author

CH4Code commented Mar 25, 2018

Hmm, cant reproduce your error. If I build mtanks, order them to force attack and deselect/select them quickly (to always show attack lines) they never stop attacking/targeting o.O
Only ground units will stop attacking a height of 400, which is intended.

@ltem

This comment has been minimized.

Copy link
Contributor

ltem commented Mar 25, 2018

Yep, this was my mistake. I reduced the ReloadDelay and the Damage of the missile tanks and saw that there is not interruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.