Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color picker actors being abstract #15001

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Mar 26, 2018

Closes #15000.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Mar 26, 2018

Could we have a new-generaion upgrade rule along?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 26, 2018

I agree we want an update rule, but it would be best if it were not tied to this specifically, but instead a more general thing that reports (without changing any yaml) that actors starting with ^ can no longer be used directly and appropriate changes should be made (maybe then with a reference back to the color picker).

@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Mar 29, 2018

Opened #15005.

@pchote
Copy link
Member

pchote left a comment

As mentioned in IRC, the color picker actors show up ingame and in the map editor. The buildable and editor filter traits will need to be removed.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:colCrash branch from fb1b7f9 to 3947a1d Mar 30, 2018

@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Mar 30, 2018

Updated.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Apr 1, 2018

Didn't test map editor since #14997 isn't merged yet (and I didn't feel like cherry-picking it), but I don't expect any issues there and the rest works fine now.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 63093eb into OpenRA:bleed Apr 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:colCrash branch Apr 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.