Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken Server.ExternalPort setting. #15003

Merged
merged 1 commit into from Mar 31, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Mar 26, 2018

The IRC discussion around #14832 highlighted the fact that most people don't understand why we have/want separate port configurations. The lack of interest in #14869 supports the idea that its not worthwhile to maintain this separation. Removing the option then also simplifies the server creation UI a bit.

Closes #14832.
Supersedes #14869.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 7be71eb into OpenRA:bleed Mar 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:remove-externalport branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.