Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upgrade rule warning about abstract actors being ignored #15005

Merged
merged 4 commits into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Mar 29, 2018

Complements #15001.

Fix line endings in upgrade rules files
- Use unix line endings
- No "\n" at the end of a message

@abcdefg30 abcdefg30 force-pushed the abcdefg30:updateAbstract branch from f4b697a to f788402 Mar 29, 2018

@pchote

pchote approved these changes Mar 30, 2018

Copy link
Member

pchote left a comment

LGTM 👍

Thanks for cleaning up a few of my oversights! As discussed in IRC, I will file another PR to fix the duplication of map-included common rules.

@pchote pchote merged commit 910064d into OpenRA:bleed Mar 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:updateAbstract branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.