New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite build after #15021

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@IceReaper
Copy link
Contributor

IceReaper commented Apr 6, 2018

preview

Yaml changes will be removed upon approvement, and before merge.

This PR is build on top of PR #15018 !

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch from 72e1013 to 65ba0d4 Apr 6, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 3 times, most recently from 1b2540a to 1f27272 Apr 7, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 3 times, most recently from 08aa9fa to bc0586a Jun 11, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 3 times, most recently from d0ea62e to cdfac80 Jul 16, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 7 times, most recently from 7ffc930 to d57f2ff Jul 25, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch from d57f2ff to 09cff4d Aug 15, 2018

@IceReaper

This comment has been minimized.

Copy link
Contributor

IceReaper commented Aug 15, 2018

Rebased.

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch from 09cff4d to a2f966f Aug 15, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 8 times, most recently from eb3eb03 to 2348bb1 Sep 26, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 2 times, most recently from 53e4b67 to fe4ca5d Oct 1, 2018

@IceReaper

This comment has been minimized.

Copy link
Contributor

IceReaper commented Oct 20, 2018

Any further comments on this? Or can i remove the example usages?

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 2 times, most recently from f227df4 to 3eb1c1c Oct 20, 2018

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 3 times, most recently from 474deb2 to bbdfcf2 Oct 25, 2018

@pchote
Copy link
Member

pchote left a comment

One last nit, then LGTM: IMO the "Building" audio notification should not play for items that are infinitely queued. Clicking on these items additional times has no in-game effect, so there should be no sound notifications.

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch 3 times, most recently from d919833 to 6ed0812 Nov 6, 2018

@IceReaper

This comment has been minimized.

Copy link
Contributor

IceReaper commented Nov 6, 2018

updated

@IceReaper IceReaper force-pushed the IceReaper:InfiniteBuildAfter branch from 6ed0812 to e9ca520 Nov 12, 2018

@pchote pchote force-pushed the IceReaper:InfiniteBuildAfter branch from e9ca520 to 6467586 Nov 17, 2018

@pchote

pchote approved these changes Nov 17, 2018

Copy link
Member

pchote left a comment

LGTM. I force-pushed over this to remove the cnc testcase and restore the comment in BeginProduction (which is still relevant).

@pchote pchote merged commit 0fca984 into OpenRA:bleed Nov 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@IceReaper IceReaper deleted the IceReaper:InfiniteBuildAfter branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment