Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create empty MissionGroups #15031

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@reaperrr
Copy link
Contributor

reaperrr commented Apr 8, 2018

Only create MissionGroups if there's at least one visible mission.

Split from #15020 to slightly bring down its diff, commit count and things to test during review.

For testing, remove all maps from one campaign category of a mods' mission.yaml of your choice, but leave the campaign category itself in.
On bleed you'd see the campaign title with no missions below, on this branch the mission group should be invisible.

Don't create empty MissionGroups
Only create MissionGroups if there's at least one visible mission.
@GraionDilach
Copy link
Contributor

GraionDilach left a comment

Looks good to me. 👍

@abcdefg30 abcdefg30 merged commit fba08cd into OpenRA:bleed Apr 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Apr 9, 2018

@reaperrr reaperrr deleted the reaperrr:invisible-missiongroups branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.