Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure BagFile.GetStream returns unique streams. #15036

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@RoosterDragon
Copy link
Member

RoosterDragon commented Apr 10, 2018

GetStream must return a unique stream on each call to ensure multiple callers can read their streams without affecting each other. As bag file returned multiple references to the same underlying stream, it was possible for multiple callers to disturb reads of each other, and thus read bad audio from each file.

Fixes regression noted recently in #14043.

Ensure BagFile.GetStream returns unique streams.
GetStream must return a unique stream on each call to ensure multiple callers can read their streams without affecting each other. As bag file returned multiple references to the same underlying stream, it was possible for multiple callers to disturb reads of each other, and thus read bad audio from each file.
@abcdefg30
Copy link
Member

abcdefg30 left a comment

Works, thank you very much! 👍 /

@abcdefg30 abcdefg30 merged commit 4da9b6f into OpenRA:bleed Apr 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Apr 10, 2018

@RoosterDragon RoosterDragon deleted the RoosterDragon:fix-bag-streams branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.