Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlayMovieInRadar crashing for spectators #15057

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Apr 14, 2018

Fixes #15051.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Apr 22, 2018

Looks good to me, but I haven't tested it.
@abcdefg30 or @KOYK can you confirm this works as advertised?

@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Apr 22, 2018

Yes, I wrote the PR. :p

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Apr 22, 2018

Yes, I wrote the PR. :p

In theory you might have done so without testing :p

@KOYK

This comment has been minimized.

Copy link
Contributor

KOYK commented Apr 23, 2018

@reaperrr
Well I tested @abcdefg30 code it by copy&paste method in openra (released version) and worked as intended, but I haven't playtested it by using the pr ( I am not even sure if that's even possible since I have no clue how pr's work)

@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Apr 23, 2018

I tested it in all mods by copying aagun.vqa into the respective bit folders and then using lua.

@reaperrr
Copy link
Contributor

reaperrr left a comment

👍 then

@reaperrr reaperrr merged commit c3bfd32 into OpenRA:bleed Apr 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Apr 23, 2018

@abcdefg30 abcdefg30 deleted the abcdefg30:specVQA branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.