Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CaptureTypes to GiveCashOnCapture. #15072

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Apr 23, 2018

Fixes #15062 (which contains a testcase). Note that IsValidCaptor is a direct copy from TransformOnCapture.

While Captures is conditional, there are several places where the game will crash if you try to implement multiple versions with different types. There are a bunch of subtle issues involved in fixing that, which are well beyond the scope of this PR.

@pchote pchote added this to the Next release milestone Apr 23, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

My testcase works 👍

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍 and I exported the issue to a ticket.

@abcdefg30 abcdefg30 merged commit 160ade1 into OpenRA:bleed Apr 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Apr 26, 2018

@pchote pchote deleted the pchote:cash-capture-types branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.