Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require PowerShell 3 or higher. #15088

Merged
merged 1 commit into from Apr 28, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Apr 28, 2018

#14855 broke compatibility with PowerShell 2. This duplicates OpenRA/OpenRAModSDK#64 to sync our requirements with the Mod SDK.

@pchote pchote added this to the Next release milestone Apr 28, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Apr 28, 2018

I have not tested this!

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Apr 28, 2018

Notcertain how to test this - pretty sure most of the devgroup has an appropriate value of PS and can't trigger the error (I have 5.1 for the matter).

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Apr 28, 2018

The simplest way (which is still a pain) would be to spin up a fresh windows 7 VM.

But this also needs to be tested on a working dev system to make sure that it isn't completely broken.

@abcdefg30 abcdefg30 merged commit d186ca3 into OpenRA:bleed Apr 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Apr 28, 2018

@pchote pchote deleted the pchote:powershell-version branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.