Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TextField.Type to prevent invalid input for filenames and integers. #15089

Merged
merged 2 commits into from May 4, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Apr 28, 2018

Supersedes #14447.

@pchote pchote force-pushed the pchote:textfield-types branch from 16ade5c to b5357e3 Apr 28, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Apr 29, 2018

Wouldn't this TextField.Type provide a necessity for an upgrade rule?

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Apr 29, 2018

That is a tricky question: where do we draw the line between mod feature additions (which shouldn't have update rules) vs engine compatibility changes (which should)?

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Apr 29, 2018

At first I misread this as something which would have introduced regressions when unset properly in third party mod UIs, but now I see that those would just lack the bugfix until modder intervention. TBH I'm okay with either case, was more of a question than a demand in particular.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote pchote added this to the Next release milestone May 4, 2018

@reaperrr reaperrr merged commit 4750188 into OpenRA:bleed May 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:textfield-types branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.