Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files included from other mods when running the mod updater. #15096

Merged
merged 3 commits into from Apr 30, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Apr 29, 2018

This PR makes the mod updater ignore any files included from a different mod. This should make life easier for "overlay-style" SDK mods that inherit from one of the default mods from the engine directory. This also fixes the duplicated ignored file warnings on the map updater.

Testcase:

  • Download / clone https://github.com/pchote/OpenRAModSDK/tree/ra-example-mod
  • Change ENGINE_VERSION to d7bb0c7 in mod.config and (re)compile.
  • Run utility.(sh|cmd) --update-mod release-20180307 --apply and notice that it updates the mod's rules.yaml and weapons.yaml but ignores all of the default RA files. The mod overrides are actually compatible with current bleed, so it will only change formatting.
@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 677d004 into OpenRA:bleed Apr 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:external-mod-update branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.