Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ITemporaryBlocker check entirely if rules contain no temporary blockers #15109

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented May 3, 2018

This benefits all mods without temporary blockers like gates or energy walls in their mod rules.

According to the tables towards the end of the #13547 discussion, the TraitOrDefault look-ups for ITemporaryBlocker are cheap individually, but since the game does so many of them, they do have a (low) performance impact.

Avoiding them altogether if the mod rules contain no temporary blocker actors should save that little bit of performance.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented May 3, 2018

Can we store that flag on World and then build the check into the WorldUtils methods instead? Putting it on LocomotorInfo doesn't feel right to me.

Skip check for ITemporaryBlocker entirely if rules don't contain any …
…temporary blockers

This benefits all mods without temporary blockers like gates or energy walls.

@reaperrr reaperrr force-pushed the reaperrr:skip-tempblocker-check branch from b29525a to cb12e24 May 4, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented May 4, 2018

Updated.

@pchote pchote added this to the Next release milestone May 4, 2018

@abcdefg30 abcdefg30 merged commit 3c34330 into OpenRA:bleed May 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented May 4, 2018

@reaperrr reaperrr deleted the reaperrr:skip-tempblocker-check branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.