Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Added HpPerStep to Repairable trait and using this value in Repair activity #15111
In the current form the repair activity is lacking the ability to set the HpPerStep for each unit with the Repairable trait. By only having this property on the RepairsUnits trait it will be hard to find a good value that works across all the repairable units in games.
For example in TD with the current HpPerStep in the live, repair time comparing to the build time on the units:
By have this be set on the trait Repairable it will enable mods to balance the repair activity in a better way.
Its been a bit of a debate back and forth on repair speeds currently. Just not obtainable due to buggies, bikes, hummers, and APCs repairing way to fast if adjusted otherwise. If this could be spread even across a bit more accurately (if im thinking this is what it does) going off base HP it could help make those adjustments. (So long as Mammoth tanks don't repair in 5 seconds anyways lol)
While you fix & squash the 2 minor nits I pointed out, please remove the "squash!" from the commit name as well.
For future reference, we usually comment with 'updated' when we've updated a PR so the reviewers notice it more quickly.