Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locomotor lint check #15115

Merged
merged 3 commits into from May 4, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented May 4, 2018

You currently won't see it in practice because the YamlException in Mobile.RulesetLoaded would hide it, but I tested it locally with that YamlException disabled.

Will become more useful once #15114 is adressed.

Also added missing entries to UpdatePath.cs.

reaperrr added some commits May 4, 2018

Group lint rules together in Mods.Common csproj
Makes it easier to manually add/remov/disable individual lint rules.
Fix Locomotor lint check
It was missing from the project file (oops...) and missing a check for duplicate Locomotor names.
Add missing update rules to bleed update path
I forgot to add these in their respective PR.

@pchote pchote added this to the Next release milestone May 4, 2018

@abcdefg30 abcdefg30 merged commit 2a42999 into OpenRA:bleed May 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented May 4, 2018

@reaperrr reaperrr deleted the reaperrr:fix-loco-lint branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.