Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE in Guard when the target actor is dead. #15122

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented May 6, 2018

Fixes #15081. As of release-20171014 order.TargetActor (which is deprecated in favour of order.Target) will return null instead of a reference to a dead actor.

@pchote pchote added this to the Next release milestone May 6, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit b8fd4ab into OpenRA:bleed May 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote referenced this pull request May 30, 2018

Closed

nullptr exception #15187

@pchote pchote deleted the pchote:fix-guard-exception branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.