Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all animation traits that would crash when more than one SpriteBody is present #15145

Merged
merged 4 commits into from Jul 1, 2018

Conversation

Projects
None yet
4 participants
@reaperrr
Copy link
Contributor

reaperrr commented May 17, 2018

The majority of With*Animation traits was not written with sprite body traits being conditional in mind and would crash if the actor has more than one With*SpriteBody trait.

This PR fixes that, by making these traits run on an assigned sprite body and simply ignore all other sprite bodies.
This indirectly now also allows having multiple of these animation traits on one actor (but still only one per sprite body).

Dependency for animation priority system.

@reaperrr reaperrr force-pushed the reaperrr:multi-wsb-support branch from aa658ca to 5aee44c Jun 3, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@Mailaender
Copy link
Member

Mailaender left a comment

Looks sensible.

@Mailaender Mailaender merged commit 1c78073 into OpenRA:bleed Jul 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Jul 1, 2018

@reaperrr reaperrr deleted the reaperrr:multi-wsb-support branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.