Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim empty space around edges of Shp(TD) frames. #15148

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
5 participants
@pchote
Copy link
Member

pchote commented May 19, 2018

This drops RA and TD both down a single sheet, reducing batches and subsequently improving render performance.

The improvement can be verified using the --dump-sequence-sheets utility command. The inefficient packing caused by icons will be addressed in the next PR.

Trim empty space around edges of Shp(TD) frames.
This significantly cuts down the amount of texture
space allocated in VRAM.
@GraionDilach
Copy link
Contributor

GraionDilach left a comment

Looks good to me.

@reaperrr reaperrr merged commit dbf6937 into OpenRA:bleed May 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented May 29, 2018

Looks like this has regressed a lot of automatically calculated selection boxes. I have rebased my engine, and had to edit a lot of selection box stuff, will check the main mods and open an issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.