Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplayer player connection notifications #15152

Merged
merged 2 commits into from May 20, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented May 20, 2018

New player notifications are now never reported to the joining player, and always reported in the dedicated server output.

This also removes the long broken DEV_VERSION warning.

Fixes #14750
Supersedes #14794

Fix player connection notifications.
New player notifications are now never reported to the joining player,
and always reported in the dedicated server output.
Remove broken DEV_VERSION warning.
This (before it was broken) was hardcoding upstream policy-specific
conventions into the core engine.

@pchote pchote force-pushed the pchote:fix-connection-notification branch from 703aead to 39b2696 May 20, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@Mailaender Mailaender merged commit 178b6b6 into OpenRA:bleed May 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented May 20, 2018

@pchote pchote deleted the pchote:fix-connection-notification branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.