Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE when updating actors with inline comments. #15156

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
5 participants
@pchote
Copy link
Member

pchote commented May 20, 2018

Fixes a regression introduced by #15125.

Repro case: try applying the AddShakeToBridge rule to RA.

@pchote pchote added this to the Next release milestone May 20, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

Confirmed the fix working.

@ltem ltem added the PR: Needs +2 label May 20, 2018

@abcdefg30 abcdefg30 merged commit a9fa9ee into OpenRA:bleed May 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented May 20, 2018

@pchote pchote deleted the pchote:fix-update-comments-crash branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.