Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MiniYaml nunit tests #15157

Merged
merged 2 commits into from May 20, 2018

Conversation

Projects
None yet
2 participants
@pchote
Copy link
Member

pchote commented May 20, 2018

Fixes #15155.

@pchote pchote force-pushed the pchote:fix-yaml-comment-test branch from c6493b4 to 0ce405a May 20, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented May 20, 2018

Fixed code style warning.


var resultKeep = MiniYaml.FromString(yaml, discardCommentsAndWhitespace: false);
var resultKeepLine = resultKeep.First(n => n.Key == "TestB").Location.Line;
Assert.That(resultKeepLine, Is.EqualTo(6), "Node TestB should report its location as line 6, but is not (discarding comments)");

This comment has been minimized.

@abcdefg30

abcdefg30 May 20, 2018

Member

Shouldn't that be a (parsing comments) as well?

Improve MiniYaml nunit tests:
- Fixes incorrectly used variable.
- Adds additional tests for node positions.

@pchote pchote force-pushed the pchote:fix-yaml-comment-test branch from 0ce405a to 5c34b27 May 20, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented May 20, 2018

Fixed.

@abcdefg30 abcdefg30 merged commit e83f5a9 into OpenRA:bleed May 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented May 20, 2018

@pchote pchote deleted the pchote:fix-yaml-comment-test branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.