Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update EmitInfantryOnSell.cs per open issue #15077 #15161
Per open issue #15077 : " having ActorTypes: e1 as a default of EmitInfantryOnSell: is inconsistent and should therefore be removed."
Removed the default setting for ActorTypes (leaving it uninitialized) and removed the reference to the default in the description
Thank you for your contribution to OpenRA!
Please be aware that we do not have enough project maintainers to match the rate of contributions, so it may take several days before somebody is able to respond to your Pull Request.
You can help speed up the review process by following a few steps:
If you need any help you can ask in the #openra IRC channel on freenode (most active during European evenings).
abcdefg30 left a comment •
Hi, and thanks for the pull request. ^^
This looks good from a first glance, however we'll want an update rule for this change. Do you want to take a shot at adding one? We can try to walk you through (on IRC) or I could provide the update rule if you want. Edit: Ah well, seems like @ABrandau was faster than I was. ^^
The point with the update rule is that your PR removes the light infantry as default unit for the trait. If someone merges your PR, selling buildings will not spawn infantry, and that is not intended, so i believe you have to correct that (I am not a dev so whatever abcdfg or anyone else says has more priority than what I say)
First you should do the manual changes for the official mods, basically look for the EmmitInfantryOnSell trait on defaults and set the e1 back in, and then make the pdate rule, I have no clue about that.
The recommended procedure is to write an update rule first, and then run that on the default mods in order to change their yaml. Doing the changes manually and then writing a rule that may or may not replicate those results is not a good idea.