Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Order.TargetActor and related fixes #15176

Merged
merged 13 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented May 27, 2018

This PR rewrites the remaining uses of Order.TargetActor to properly use Targets.
It also fixes order queuing for repair and passenger orders.

Fixes #15166.
Fixes #15146.
Fixes #15085.
Related to #11265, #14872.

@pchote pchote added this to the Next release milestone May 27, 2018

@reaperrr
Copy link
Contributor

reaperrr left a comment

Code looks good to me, didn't encounter any in-game issues either

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

LGTM. 👍

@reaperrr reaperrr merged commit ba8eac0 into OpenRA:bleed May 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:remove-order-targetactor branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.