Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send additional mod metadata in master server game advertisements #15185

Merged
merged 4 commits into from May 31, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented May 29, 2018

This PR sends three new fields to the master server:

  • ModTitle includes the mod's human readable title.
  • ModWebsite includes the mod's website URL (new mod.yaml field).
  • ModIcon32 includes a URL to a web-hosted version of the mod's icon (new mod.yaml field, WebIcon32, should match icon.png).

The ModTitle is used as the primary source of the mod name in the server list, and so fixes the "Unknown mod (id)"'s in the server list (for mods that have been updated to include this PR).

The other fields will be used in the web server listings, and I plan a future PR (probably not this cycle) to use them in a dialog similar to the mod-switch dialog when double clicking on a server for a mod that isn't installed and/or mod header tooltip.

Depends on OpenRA/OpenRAMasterServer#56 (already merged).
Depends on OpenRA/OpenRAWeb#383 - the master server will complain about missing icons, but still accept the rest of the data.

@pchote pchote added this to the Next release milestone May 29, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented May 30, 2018

ModIcon32 includes the mod's website URL (new mod.yaml field, WebIcon32, should match icon.png).

C'N'P error in the initial post?

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented May 30, 2018

Fixed initial post.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote pchote added the PR: Needs +2 label May 30, 2018

@reaperrr reaperrr merged commit 3a18578 into OpenRA:bleed May 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:additional-mod-metadata branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.