Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blink the color picker Palette tab when the Store button is pressed. #15197

Merged
merged 2 commits into from Jun 2, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Jun 1, 2018

This improves the usability and discoverability of #14853 by blinking the palette tab when the Store button is pressed from the mixer tab. Without this, players could quite easily miss the custom color functionality and/or think that it is a broken "apply" button.

pchote added some commits Jun 1, 2018

Blink the color picker palette tab when the Store button is pressed.
This provides some visual feedback that something
has happened on the hidden tab.

@pchote pchote added this to the Next release milestone Jun 1, 2018

@pchote pchote changed the title Blink colorpalette on store Blink the color picker Palette tab when the Store button is pressed. Jun 1, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

LGTM

@reaperrr reaperrr merged commit 3d79541 into OpenRA:bleed Jun 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:blink-colorpalette-on-store branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.