Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix RA/TD selection/decoration/interaction bounds #15198
The dynamic/per-frame 'canvas' for SHP(TD) introduced by #15148 messed up the old auto-calculation assumptions.
We already use fixed bounds in most other places (D2k, TS, all moving actors in RA and TD, several structures in RA/TD), so finishing the job for RA/TD buildings is the easiest way to fix #15184, avoiding both reversion of #15148 as well as code-level work-arounds.
referenced this pull request
Jun 1, 2018
Tested the changes in ra, cnc and ts. In ra and cnc the bounds for civilian buildings/tech buildings are fine, in ts only the scrin ship needs adjustments.
See https://imgur.com/a/VbWDHB8 for screenshots of selected civilian buildings per mod. Note that those buildings in the screenshots that are not selected (couldn't select them for some reason) have correct bounds too.
Edit: Selectable bounds of buildings like ra's windmill or oil derrick and ts' civilian array that have animated components look good too.
Added RA/TD tech buildings to be on the safe side.
@lawando It could be (but I haven't checked yet) that the damaged frame of the civ buildings alters the bounds a bit. That's pretty much the only possible issue to look out for, though.
TS Scrin ship should look like that before #15148 already.
I have added a section to https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-release-20180307-to-next-release to make modders aware of this change.