Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix tooltip descriptions for spectators. #15203
Other than I expected the tooltip description can be shown to spectators if set to true. Please pardon my lack of understanding and knowledge, it's a learning process for me and I'm willing to improve.
It will be required to control which tooltip descriptions in case of multiple instances of the trait should be shown to spectators or add a description that is only shown to spectators. My current idea is to add a "generic description" that is not aimed at players of a certain stance, integrate
It looks like a proper implementation requires the spectator stances from #15160 which are assigned to next +1 while this is assigned to next release. IMO showing all descriptions to spectators looks broken so I suggest we either disable them for spectators until we have the spectator stances (preferably) or we revert #15144 entirely.
referenced this pull request
Jun 17, 2018
Spectators will see the descriptions for either the neutral stance or the allied stance. The reason that I removed