Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CheckDeathTypes lint test. #15210

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@pchote
Copy link
Member

pchote commented Jun 3, 2018

This lint test was originally added years ago when WithDeathAnimation was used exclusively for infantry, and missing a definition caused a crash (e.g #8266, #8305). The exception throwing was removed in #8742, and so this test now causes more harm than good by flagging false positives whenever a mod wants to use SpawnActorOnDeath to trigger a custom effect on some death types, knowing/wanting/expecting nothing to happen in other cases.

Fixes @ABrandau's complaint in #15201.

Remove CheckDeathTypes lint test.
This causes false positive errors when mods use
SpawnActorOnDeath to implement special-case death
effects.
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Jun 4, 2018

Actually, I think this is obvious and risk-free enough to not need another +1, so lgtm.

@reaperrr reaperrr merged commit df95b90 into OpenRA:bleed Jun 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:remove-deathtypes-lint branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.