Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SupportPowerDecisions to a single parent node. #15263

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Jun 14, 2018

This PR solves the last prerequisite for #15201. The SupportPowerDecisions currently defined directly on HackyAI do not match a TraitInfo field, so are detected as unused/junk nodes.

The update rule would benefit from #15219, but I didn't want to make this depend on that considering the current lack of movement on the update rule PRs.

Move SupportPowerDecisions to a single parent node.
This is required before we can force all trait
properties to match a TraitInfo-defined field.
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 14, 2018

I recommend reviewing this with ?w=1 to suppress the indentation changes.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@ltem ltem added the PR: Needs +2 label Jun 14, 2018

@reaperrr reaperrr merged commit cce9b06 into OpenRA:bleed Jun 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:move-supportpower-decisions branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.