Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special-case the player actor in GrantConditionOnBotOwner. #15272

Merged
merged 1 commit into from Jul 28, 2018

Conversation

Projects
None yet
4 participants
@GraionDilach
Copy link
Contributor

GraionDilach commented Jun 17, 2018

Player.IsBot is set only after GrantConditionOnBotOwner.Created
have already ran, preventing the trait to work on the Player
actor itself.

@GraionDilach GraionDilach changed the title Special-case the player actor in GCOnBotOwner. Special-case the player actor in GrantConditionOnBotOwner. Jun 17, 2018

@pchote pchote added this to the Future milestone Jun 30, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jun 30, 2018

Moving to the Future milestone so we don't lose this.

@GraionDilach GraionDilach reopened this Jul 19, 2018

@abcdefg30 abcdefg30 removed this from the Future milestone Jul 19, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jul 26, 2018

Could this be done more simply by queuing a FrameEndTask from Create? IIRC that's what we do in other cases that have similar ordering issues.

@GraionDilach

This comment has been minimized.

Copy link
Contributor Author

GraionDilach commented Jul 26, 2018

Will try when I get home.

@GraionDilach GraionDilach force-pushed the GraionDilach:gcoai-player-handling branch from 60e0bde to b29de04 Jul 26, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor Author

GraionDilach commented Jul 26, 2018

Did it with FrameEndTask - it still works. Added testcase, only AIs should be able to build riflemen in RA.

@GraionDilach GraionDilach dismissed stale reviews from abcdefg30 and chrisforbes via 9bc9e34 Jul 28, 2018

@GraionDilach GraionDilach force-pushed the GraionDilach:gcoai-player-handling branch from b29de04 to 9bc9e34 Jul 28, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor Author

GraionDilach commented Jul 28, 2018

Removed testcase.

@abcdefg30 abcdefg30 merged commit 51a99cb into OpenRA:bleed Jul 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GraionDilach GraionDilach deleted the GraionDilach:gcoai-player-handling branch Jul 28, 2018

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.