Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeathTypes to OwnerLostAction. #15279

Merged
merged 2 commits into from Jun 30, 2018

Conversation

Projects
None yet
4 participants
@GraionDilach
Copy link
Contributor

GraionDilach commented Jun 18, 2018

Something I overlooked back at reviewing #14982. Would be cool if it would hit the playtest, because it is a good polish. I've enabled the first deathtype in all mods because that was the case in RA and TS (notsure what D2K used originally.)

Fixes #12802.

@GraionDilach GraionDilach force-pushed the GraionDilach:ownerlostaction-deathtypes branch from fdf8f76 to f369d8d Jun 18, 2018

@ABrandau

This comment has been minimized.

Copy link
Contributor

ABrandau commented Jun 19, 2018

I edited the yamls to make infantry spawn visceroids when the player surrenders, then changed it to flameguy, it works in both ways.

As a side note, buildings lack OwnerLostAction.

@GraionDilach

This comment has been minimized.

Copy link
Contributor Author

GraionDilach commented Jun 24, 2018

Buildings don't lack OLA, they just don't need a deathtype on their OLA - in all the default mods, the building explosions aren't linked to such, but appear unconditionally.

@pchote pchote added this to the Future milestone Jun 30, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jun 30, 2018

Moving to the Future milestone so we don't lose this.

@MustaphaTR do you want to take this one over so we can prioritize it for the playtest?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jun 30, 2018

Actually this already has a 👍 so i'll add it to my review list, then we can merge it as-is if there aren't any issues.

@pchote pchote reopened this Jun 30, 2018

@pchote

pchote approved these changes Jun 30, 2018

@pchote pchote merged commit b892336 into OpenRA:bleed Jun 30, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@GraionDilach GraionDilach deleted the GraionDilach:ownerlostaction-deathtypes branch Jun 30, 2018

@abcdefg30 abcdefg30 removed this from the Future milestone Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.