Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AppImage workaround to import SSL certs. #15291

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Jun 23, 2018

Fedora, self-compiled mono installations, and probably a few other distros fail to set up the SSL certificates needed for https web queries.

This PR adds a workaround adapted from the Flatpak packaging to locally import the system certificates to ~/.config/.mono/certs where OpenRA can use them.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 23, 2018

Test build, which I have confirmed to (a) fix web queries on Fedora 28 and (b) not break anything on Ubuntu 18.04.

@pchote pchote added this to the Next release milestone Jun 23, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Jun 24, 2018

Don't have a Linux in hand atm, but I presume this works then and so .

@LyzardKing

This comment has been minimized.

Copy link

LyzardKing commented Jun 26, 2018

Hi. I tested this appimage on ubuntu 18.04.
I get an error saying it requires mono 4.2 or greater..
Do I have to install the system version of mono via apt?

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 26, 2018

Yes indeed. Try running sudo apt install mono-complete.

@LyzardKing

This comment has been minimized.

Copy link

LyzardKing commented Jun 26, 2018

Ah ok. I thought it was included in the appimage.
Downloading the mono dependencies now...
Will the final appimage contain mono as well?

EDIT: It seems to work properly on 18.04!

@abcdefg30 abcdefg30 merged commit 1b63d65 into OpenRA:bleed Jun 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jun 26, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 26, 2018

Will the final appimage contain mono as well?

Unfortunately not. Bundling mono inside the AppImages would increase the file size significantly and initial tests (discussed in #12257 and linked issues) failed to get mono working at all.

One simple thing that we can do on Ubuntu (and other apt based distros), however, is to automatically pop up a mono installation dialog using the AptURL specification.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 26, 2018

Added in #15299.

@pchote pchote referenced this pull request Jun 27, 2018

Closed

Finish Mod SDK TODOs #15229

4 of 4 tasks complete

@pchote pchote deleted the pchote:appimage-cert-sync branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.