Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppImage prompt to install mono-complete package using apt-url #15299

Merged
merged 3 commits into from Jul 4, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Jun 26, 2018

This PR aims to improve the first-run flow on apt-based distributions, leveraging the apt:// URL integration in the respective software centers.

From the AppRun.in comment:

# If mono is not installed, and the user has apt-cache, apt-url,
# xdg-open, and either zenity or kdialog, then we can prompt to
# automatically install the mono-complete package

The standard dialog (now extended with a link to the wiki) continues to show on other distros (tested Fedora 28 and CentOS 7), or if the prompt is declined.

Gnome:
screen shot 2018-06-26 at 21 41 49
screen shot 2018-06-26 at 22 03 31
screen shot 2018-06-26 at 22 03 19

KDE:
screen shot 2018-06-26 at 22 39 31
screen shot 2018-06-26 at 22 40 01

@pchote

This comment has been minimized.

@fusion809

This comment has been minimized.

Copy link
Contributor

fusion809 commented Jun 30, 2018

If it helps I've started up a MX Linux 17.1 VM and tried executing this AppImage from the command-line and while I expected a Zenity GUI to popup and tell me to install mono-complete, I at least got a message from the command-line telling me this, presumably because Zenity wasn't installed (doesn't seem to be shipped with this distro). Once Mono was installed it ran splendidly.

AppImages usually contain everything that cannot be reasonably expected to be provided by the host system, so I'm guessing for some reason Mono wasn't willing to come along for the ride within in the AppImage and that's why the AppImage needs the host to provide Mono.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 30, 2018

Does MX Linux provide by default any other tools for creating a graphical prompt? Maybe python with GTK or QT bindings?

There are two big issues with including mono:

  • Nobody seems to know how to make it work inside an AppImage, and I don't have time to try and solve it myself.
  • Bundling mono would increase the download size by a factor of probably ~10.

IMO this more than qualifies as "cannot reasonably be expected" 😄

@fusion809

This comment has been minimized.

Copy link
Contributor

fusion809 commented Jun 30, 2018

Well I know the package python-gtk2 comes pre-installed, if that is relevant, along with python-gi, python3-gi and python-gobject. I think the python-gtk2 is the old deprecated Python GTK+2 bindings, while the python-gi and python3-gi provides the newer ones.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jun 30, 2018

Ok. I filed #15311 for that, as it is out of scope for this PR (which explicitly falls back to the current bleed behaviour if zenity isn't available).

@Mailaender
Copy link
Member

Mailaender left a comment

Looks okay and doesn't break things on openSUSE.

make_version() {
echo "$1" | tr '.' '\n' | head -n 4 | xargs printf "%03d%03d%03d%03d";
echo "$1" | tr '.' '\n' | head -n 4 | xargs printf "%03d%03d%03d%0a3d";

This comment has been minimized.

@pchote

pchote Jul 1, 2018

Author Member

Looks like I accidentally introduced a typo here.

@pchote pchote force-pushed the pchote:appimage-apturl branch from 72f0bf6 to 6156612 Jul 1, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jul 1, 2018

Fixed and rebased.

@pchote pchote force-pushed the pchote:appimage-apturl branch from 6156612 to b61a42d Jul 1, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jul 1, 2018

Rebased again to get this on top of the crlf fixes.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jul 4, 2018

I'm going to merge this without a :+2: because it is blocking other work needed for the playtest and we don't have any other active reviewers with the capabilities to give this a proper review. I'm happy with this as-is and will take responsibility for fixing any regressions if they are found in the future.

@pchote pchote merged commit 29442ce into OpenRA:bleed Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:appimage-apturl branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.