Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify RA unit buildtime yaml and game rules for Tier 3 units. #15302

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
4 participants
@SoScared
Copy link
Member

SoScared commented Jun 27, 2018

This is something I've recently fixed with my own mod. RA's Tier 3 (Tech Center) units has a shorter buildtime duration of around 15-20% which was introduced with #13790, but was introduced a bit clumsy due to my lack of understanding how the properties worked.

Replacing all custom build times with BuildDurationModifier: 50 (default is 60) makes for all units (except MAD Tank and Demo Truck) being produced precisely 20% faster. This clean-up results with:

MCV, Mammoth Tank

  • 40s (no change)

Phase/Chrono/Tesla Tank

  • 28s -> 27s

Mobile Radar Jammer

  • 22s (no change)

Mobile Gap Generator

  • 24s (no change)

Longbow/MiG

  • 42s -> 40s

Missile Sub

  • 42s -> 40s

Cruiser

  • 48s (no change)

Ping @Smittytron

I found it a bit amusing how close these values was to a simple catch-all line of code. You could argue it's good to have a consistent value the user can relate to and memorize (Tier 3 units produces 20% faster) and could ease future balancing, avoiding looking at arbitrary build time values.

@pchote pchote added this to the Next release milestone Jun 27, 2018

@pchote

pchote approved these changes Jun 27, 2018

Copy link
Member

pchote left a comment

Seems reasonable to me. 👍 for the implementation approach - I have not tested this ingame or verified the before/after duration numbers.

@Smittytron
Copy link
Contributor

Smittytron left a comment

LGTM

@abcdefg30 abcdefg30 merged commit fa29a4b into OpenRA:bleed Jun 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.