Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback error dialog for AppImages using Python. #15316

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
1 participant
@pchote
Copy link
Member

pchote commented Jul 1, 2018

Fixes #15311.
Depends on #15299.

I have tested and confirmed this to work on both MX Linux as originally reported and Ubuntu (after manually breaking the zenity package). Note that the transient dialog error is a feature of gnome, and both zenity and the apt-url dialog report the same message.

screen shot 2018-07-01 at 18 08 01
screen shot 2018-07-01 at 17 42 52
screen shot 2018-07-01 at 17 47 42
screen shot 2018-07-01 at 17 49 25

Test AppImage: https://www.dropbox.com/s/of46hufiiiapfwe/OpenRA-Red-Alert-pygtk-x86_64.AppImage?dl=1

@pchote pchote added this to the Next release milestone Jul 1, 2018

@pchote pchote force-pushed the pchote:appimage-pygtk branch from f5d777f to 30e8f2d Jul 4, 2018

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jul 4, 2018

I'm going to merge this without a 👍 because it is blocking other work needed for the playtest, and we don't have any active reviewers with the capabilities to give this a proper review. I'm happy with this as-is and will take responsibility for fixing any regressions if they are found in the future.

@pchote pchote merged commit 01a613a into OpenRA:bleed Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:appimage-pygtk branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.