Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TS mechs display walk anim while turning #15317

Merged
merged 3 commits into from Jul 19, 2018

Conversation

Projects
None yet
5 participants
@reaperrr
Copy link
Contributor

reaperrr commented Jul 1, 2018

Matches the original (and looks better, too).

Closes #13346.

@Smittytron
Copy link
Contributor

Smittytron left a comment

Looks good.
I noticed the Mammoth Mk II seems to walk while turning with or without this.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Jul 5, 2018

I noticed the Mammoth Mk II seems to walk while turning with or without this.

Yeah, WithVoxelWalkerBody did its own thing (checking both IsMoving and whether the current facing mismatches the previous facing).

I removed the now-redundant facing check from WithVoxelWalkerBody, please check if the Mk2 still works as intended on this PR, just to be sure.

@Smittytron
Copy link
Contributor

Smittytron left a comment

Yep, works the same.

@@ -225,6 +225,10 @@ public override Activity Tick(Actor self)
{
path.Add(nextCell.Value.First);

// If Mobile.Info.AlwaysConsiderTurnAsMove is true, we consider Turn as movement regardless of facing delta size.
// This is needed for actors that want to display their movement animation during turns (walker units, for example).

This comment has been minimized.

@pchote

pchote Jul 6, 2018

Member

Can you please add to this comment where this gets set back to false?

reaperrr added some commits Jun 9, 2018

Make TS mechs display walk anim while turning
This matches the original, and turning without moving their legs looked silly either way.
Add AlwaysConsiderTurnAsMove plumbing to Mobile
Can be used to make walker units like the TS mechs display move animations while turning on the spot.
Remove facing check from WithVoxelWalkerBody
`Mobile` now supports considering turning as `IsMoving`, so this check is no longer needed.

@reaperrr reaperrr force-pushed the reaperrr:fix-TS-mech-walkanims branch from c08423d to 6fa6a13 Jul 6, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Jul 6, 2018

Updated comment.

@Mailaender
Copy link
Member

Mailaender left a comment

Works as promised.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 496155f into OpenRA:bleed Jul 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:fix-TS-mech-walkanims branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.