Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending HTTP requests to the FetchNews URL when FetchNews is disabled #15324

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
4 participants
@obrakmann
Copy link
Contributor

obrakmann commented Jul 4, 2018

Also disables the 'Send SysInfo' settings checkbox when 'Fetch News' is disabled as well.

Closes #14787

Avoid sending HTTP requests to the FetchNews URL when FetchNews is di…
…sabled

Also disables the 'Send SysInfo' settings checkbox when 'Fetch News' is disabled as well.
@pchote

pchote approved these changes Jul 4, 2018

@pchote pchote added the PR: Needs +2 label Jul 4, 2018

@pchote pchote added this to the Next release milestone Jul 4, 2018

@matjaeck
Copy link
Contributor

matjaeck left a comment

Checkbox text for ssi greys out when disabled so it's easy to understand that it depends on enabled fetch news . Wireshark shows no HTTP request when fetchnews is disabled. I guess there are reasons for having ssi and fetchnews linked together so LGTM.

@reaperrr reaperrr merged commit 3e29ef0 into OpenRA:bleed Jul 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Jul 5, 2018

@obrakmann obrakmann deleted the obrakmann:fix14787_avoid-unwanted-http-request branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.