Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Parachutable.GroundCorpseSequence default to null #15326

Merged
merged 3 commits into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@reaperrr
Copy link
Contributor

reaperrr commented Jul 5, 2018

Missions and 3rd-party mods may paradrop vehicles which normally don't need a corpse sequence (because they already have Explodes), so the old infantry-centric internal default can cause more harm than good.

Additionally, made it easier to disable inherited corpse sequences (checking Image + using NullOrEmpty instead of just null checks) and improved internal order and readability of the properties a bit.

reaperrr added some commits Jun 8, 2018

Change Parachutable.GroundCorpseSequence default to null
Missions and 3rd-party mods may paradrop vehicles which normally don't need a corpse sequence (because they already have Explodes), so the old infantry-centric internal default can cause more harm than good.
@abcdefg30
Copy link
Member

abcdefg30 left a comment

Why aren't we setting corpse as value for GroundCorpseSequence if the sequence was not defined before? (But only list the locations?) Inheritance?

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Jul 5, 2018

Inheritance?

Pretty much. Well, I wasn't 100% sure which way to go, but I figured that not doing things automatically would be the lesser evil over potentially adding some unwanted override just because that actor happens to use a custom FallRate or something like that.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote

pchote approved these changes Jul 26, 2018

@pchote pchote merged commit d07bd02 into OpenRA:bleed Jul 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:para-corpse-disable branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.