Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pathfinding calc when the distance was to small for the bidire… #15339

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
4 participants
@teinarss
Copy link
Contributor

teinarss commented Jul 10, 2018

Fixes #15054 and #6989

@teinarss teinarss force-pushed the teinarss:pathfinding-fixes branch from 6170fca to e9915d8 Jul 10, 2018

@teinarss

This comment has been minimized.

Copy link
Contributor Author

teinarss commented Jul 10, 2018

Updated: fixed it in another way.

@@ -70,6 +70,11 @@ public List<CPos> FindUnitPath(CPos source, CPos target, Actor self, Actor ignor
if (domainIndex != null && !domainIndex.IsPassable(source, target, li))
return EmptyPath;

var distance = source - target;

This comment has been minimized.

@abcdefg30

abcdefg30 Jul 10, 2018

Member

Please remove the empty line here as well.

@teinarss teinarss force-pushed the teinarss:pathfinding-fixes branch from e9915d8 to 05135fa Jul 11, 2018

@teinarss

This comment has been minimized.

Copy link
Contributor Author

teinarss commented Jul 11, 2018

Updated: removed empty line and using LengthSquared

@teinarss teinarss closed this Jul 11, 2018

@teinarss teinarss reopened this Jul 11, 2018

@abcdefg30 abcdefg30 merged commit 25a8de8 into OpenRA:bleed Jul 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jul 12, 2018

@drogoganor

This comment has been minimized.

Copy link
Contributor

drogoganor commented Jul 18, 2018

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.