Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GivesBounty>LevelMod #15342

Merged
merged 2 commits into from Jul 26, 2018

Conversation

Projects
None yet
6 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Jul 12, 2018

Closes #14381. Its effect can be recreated using conditions, as first commit fixes the issue with passengers having multipile GivesBounty traits.

I didn't do that to RA mod tho. I know we wanted to remove this for a while now. This will effect balancing so i would like to hear some words from people looking for these stuff too.

This probably needs a update rule, not sure if i can write a proper one or i should just add a notice but first seems less likely as it is a bit complicated.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:remove-level-mod branch from 5f5ddd2 to 6b92f56 Jul 12, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

Works as advertised. I agree with this method most as I stated in #14381.

@WhoCaresora

This comment has been minimized.

Copy link

WhoCaresora commented Jul 15, 2018

I agree to remove extra bounty on vet units.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍 but needs a followup/ticket to mention that passengers are killed without transferring damagetypes (and fixing that will require to update GetDisplayedBountyValue as well).

@pchote

pchote approved these changes Jul 26, 2018

@pchote pchote merged commit 6b1451f into OpenRA:bleed Jul 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:remove-level-mod branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.