Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct effects for TD anti-air explosions #15348

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
5 participants
@Smittytron
Copy link
Contributor

Smittytron commented Jul 14, 2018

Closes #15248

@ABrandau

This comment has been minimized.

Copy link
Contributor

ABrandau commented Jul 14, 2018

You could consider setting up an inheritance system for the explosions, that way you dont need to repeat the same on every weapon (makes updating easier)

@Smittytron Smittytron force-pushed the Smittytron:td-aa-effects branch from d4ab5eb to 9d9231d Jul 15, 2018

@Smittytron

This comment has been minimized.

Copy link
Contributor Author

Smittytron commented Jul 15, 2018

Updated. Removed unnecessary lines from effect overrides.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote

pchote approved these changes Jul 26, 2018

Copy link
Member

pchote left a comment

Seems reasonable to me 👍

@pchote pchote merged commit 1ffe87b into OpenRA:bleed Jul 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Smittytron Smittytron deleted the Smittytron:td-aa-effects branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.